On Tue, Jul 11, 2023 at 10:55:40AM +0800, Huqiang Qin wrote: > Hi Conor, > > On 2023/7/11 0:38, Conor Dooley wrote: > >> diff --git a/Documentation/devicetree/bindings/pinctrl/amlogic,meson-pinctrl-a1.yaml b/Documentation/devicetree/bindings/pinctrl/amlogic,meson-pinctrl-a1.yaml > >> index 99080c9eaac3..e019b6aa6ca3 100644 > >> --- a/Documentation/devicetree/bindings/pinctrl/amlogic,meson-pinctrl-a1.yaml > >> +++ b/Documentation/devicetree/bindings/pinctrl/amlogic,meson-pinctrl-a1.yaml > >> @@ -17,6 +17,7 @@ properties: > >> enum: > >> - amlogic,meson-a1-periphs-pinctrl > >> - amlogic,meson-s4-periphs-pinctrl > >> + - amlogic,c3-periphs-pinctrl > > Alphanumerical order here perhaps? > > Okay > > > > >> +++ b/include/dt-bindings/gpio/amlogic-c3-gpio.h > >> @@ -0,0 +1,72 @@ > >> +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */ > > Any reason to deviate from the usual license terms for bindings, which is > > "GPL-2.0-only OR BSD-2-Clause"? > > I initially used the license commonly used by Amlogic (reference: meson-s4-gpio.h): > ``` > /* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */ > ``` > > But when I checked the patch, some warnings appeared: > ``` > WARNING: DT binding headers should be licensed (GPL-2.0-only OR .*) > #37: FILE: include/dt-bindings/gpio/amlogic-c3-gpio.h:1: > +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */ > ``` > So I followed the prompts and changed the license. > > Can I ignore this warning and use the (GPL-2.0+ OR MIT) license? If the tools are happy then I suppose you are okay.. I'll leave that to Rob or Krzysztof, but if you have a reason for diverging that seems fine to me. Thanks, Conor.
Attachment:
signature.asc
Description: PGP signature
