On 11/07/2023 07:55, Jayesh Choudhary wrote: > Hello Krzysztof, > > On 10/07/23 17:11, Krzysztof Kozlowski wrote: >> On 10/07/2023 12:27, Jayesh Choudhary wrote: >>> SERDES4 has 4 lanes. Add lane definitions for it. >>> >>> Signed-off-by: Jayesh Choudhary <j-choudhary@xxxxxx> >>> --- >>> include/dt-bindings/mux/ti-serdes.h | 20 ++++++++++++++++++++ >> >> Where are the users of this binding constants? IOW, why do you need to >> add these? >> >> I don't see users of existing constants either... >> > > These constants are propagated in the idle-state property for the > mux-controller node (named serdes_ln_ctrl) usually in the final > board dts files and occasionally in the main dtsi files for TI SoCs. So they are not used. Do not add headers which are not used - neither to the kernel sources, nor to the DTSI. The header constants don't even look as suitable for bindings, although this is tricky to judge without users. Best regards, Krzysztof
