Am Montag, 10. Juli 2023, 16:16:20 CEST schrieb Heiko Stuebner: > On Fri, 7 Jul 2023 08:33:33 +0200, Krzysztof Kozlowski wrote: > > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. > > These are simple defines so they could be used in DTS but they will not > > have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE. > > > > Correct the interrupt flags, assuming the author of the code wanted same > > logical behavior behind the name "ACTIVE_xxx", this is: > > ACTIVE_HIGH => IRQ_TYPE_LEVEL_HIGH > > > > [...] > > Applied, thanks! > > [1/3] arm64: dts: rockchip: correct wifi interrupt flag in eaidk-610 > commit: 8183bb7e291b7818f49ea39687c2fafa01a46e27 > [2/3] arm64: dts: rockchip: correct wifi interrupt flag in Rock Pi 4B > commit: cfa12c32b96fd5b12f77d880d6a1ddd2a502756e > [3/3] arm64: dts: rockchip: correct wifi interrupt flag in Box Demo > commit: 2d6f7e3938a7aba154c8e8afaddc8b7f1e0a1b56 we got one successful test and all the changes concern broadcom wifi modules, I assume that this should work on all of them the same :-)
