Re: [PATCH 1/4] dt-bindings: pinctrl: qcom-pmic-gpio: Add pm7550ba support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6.07.2023 16:45, Rohit Agarwal wrote:
> 
> On 7/6/2023 8:05 PM, Krzysztof Kozlowski wrote:
>> On 06/07/2023 15:30, Rohit Agarwal wrote:
>>> Add support for the pm7550ba GPIO support to the Qualcomm PMIC GPIO
>>> binding.
>>>
>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@xxxxxxxxxxx>
>>> ---
>>>   Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 3 +++
>> I doubt that all your patches here and other patchsets are v1. Otherwise
>> how did you get my Acks and Rbs? Please use proper versioning and
>> provide changelog.
>>
>> What changed here?
> 
> Actually this is part of the original bigger series [1] that as per Bjorn's suggestion need to be broken
> down according to the subsystem/maintainer.
> Since it got broken down into multiple smaller series, I didnt include the versioning.
All of that information should be included in the cover letter, to
limit confusion both for maintainers and patch workflow tools.

Since these patches all come from a separate series, it would be
good for you to version this one as v(BIG_SERIES_REVISION)+1 because
they've already been on LKML at least once. That would especially hold
true if this revision included any changes.

Konrad
> 
> [1] https://lore.kernel.org/all/9de424ca-271a-8ed2-5550-658a828c4ea5@xxxxxxxxxxx/
> 
>>
>> Best regards,
>> Krzysztof
>>



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux