Hi Krzysztof, On Thu, Jul 6, 2023 at 2:01 PM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 06/07/2023 05:43, 运辉崔 wrote: > > Hi Conor, > > > > Added dts Maintainers, > > > > On Wed, Jul 5, 2023 at 11:07 PM Conor Dooley <conor@xxxxxxxxxx> wrote: > >> > >> Hey, > >> > >> On Wed, Jul 05, 2023 at 07:42:51PM +0800, Yunhui Cui wrote: > >>> Add the description for ffitbl subnode. > >>> > >>> Signed-off-by: Yunhui Cui <cuiyunhui@xxxxxxxxxxxxx> > >>> --- > >>> .../devicetree/bindings/firmware/ffitbl.txt | 27 +++++++++++++++++++ > >>> MAINTAINERS | 1 + > >>> 2 files changed, 28 insertions(+) > >>> create mode 100644 Documentation/devicetree/bindings/firmware/ffitbl.txt > >>> > >>> diff --git a/Documentation/devicetree/bindings/firmware/ffitbl.txt b/Documentation/devicetree/bindings/firmware/ffitbl.txt > >>> new file mode 100644 > >>> index 000000000000..c42368626199 > >>> --- /dev/null > >>> +++ b/Documentation/devicetree/bindings/firmware/ffitbl.txt > >> > >> Firstly, new dt-bindings need to be done in yaml, not in text form. > >> Secondly, you didn't re-run get_maintainer.pl after adding this binding, > >> so you have not CCed any of the other dt-binding maintainers nor the > >> devicetree mailing list. > > > > Re-run get_maintainer.pl and added maintainers into the maillist. > > > This does not work like this. > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > You missed at least DT list (maybe more), so this won't be tested by our > tools. Performing review on untested code might be a waste of time, thus > I will skip this patch entirely till you follow the process allowing the > patch to be tested. > > Please kindly resend and include all necessary To/Cc entries. This set of patches is applied on the tag next-20230706, and to generate the mail list by scripts/get_maintainers.pl on the tag ./scripts/get_maintainer.pl ../riscv/linux/v3-0004-dt-bindings-firmware-Document-ffitbl-binding.patch Yunhui Cui cuiyunhui@xxxxxxxxxxxxx (maintainer:FDT FIRMWARE INTERFACE (FFI)) Rob Herring <robh+dt@xxxxxxxxxx> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) Conor Dooley <conor+dt@xxxxxxxxxx> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) devicetree@xxxxxxxxxxxxxxx (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) linux-kernel@xxxxxxxxxxxxxxx (open list) What am I missing ? > > emm.. There is some *txt in > > Documentation/devicetree/bindings/firmware/, isn't it? > > And what about it? Do you claim they were added recently? > > Best regards, > Krzysztof > Thanks, Yunhui
