On Mon, Dec 8, 2014 at 9:29 AM, Josh Wu <josh.wu@xxxxxxxxx> wrote: > + priv->master_clk = devm_clk_get(&client->dev, "xvclk"); > + if (IS_ERR(priv->master_clk)) > + return -EINVAL; You should return PTR_ERR(priv->master_clk) instead. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html