On Tue, Jul 04, 2023 at 04:20:18PM +0100, Suzuki K Poulose wrote:
> On 05/05/2023 20:51, Frank Li wrote:
> > Add coresight trace components (ETM, ETF, ETB and Funnel).
> >
> > ┌───────┐ ┌───────┐ ┌───────┐
> > │ CPU0 ├─►│ ETM0 ├─►│ │
> > └───────┘ └───────┘ │ │
> > │ │
> > ┌───────┐ ┌───────┐ │ ATP │
> > │ CPU1 ├─►│ ETM1 ├─►│ │
> > └───────┘ └───────┘ │ │
> > │ FUNNEL│
> > ┌───────┐ ┌───────┐ │ │
> > │ CPU2 ├─►│ ETM2 ├─►│ │
> > └───────┘ └───────┘ │ │ ┌─────┐ ┌─────┐
> > │ │ │ │ │ │
> > ┌───────┐ ┌───────┐ │ │ │ M7 │ │ DSP │
> > │ CPU3 ├─►│ ETM3 ├─►│ │ │ │ │ │
> > └───────┘ └───────┘ └───┬───┘ └──┬──┘ └──┬──┘ AXI
> > │ │ │ ▲
> > ▼ ▼ ▼ │
> > ┌───────────────────────────┐ ┌─────┐ ┌─┴──┐
> > │ ATP FUNNEL ├──►│ETF ├─► │ETR │
> > └───────────────────────────┘ └─────┘ └────┘
> >
> > Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 179 ++++++++++++++++++++++
> > 1 file changed, 179 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > index a19224fe1a6a..0fa74477b9e1 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > @@ -304,6 +304,185 @@ soc: soc@0 {
> > nvmem-cells = <&imx8mp_uid>;
> > nvmem-cell-names = "soc_unique_id";
> > + etm0: etm@28440000 {
> > + compatible = "arm,coresight-etm4x", "arm,primecell";
> > + reg = <0x28440000 0x10000>;
> > + arm,primecell-periphid = <0xbb95d>;
>
> Why is this needed (and for all the ETMs) ?
Reg size is wrong set to 64k(should be 4k), so crash when call amba_read_periphid().
let me send out a fixed patch.
Thank you for found it.
Frank
>
> Suzuki
>
