Re: [PATCH v2 2/2] leds: pca995x: Add support for PCA995X chips

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/5/23 09:11, Krzysztof Kozlowski wrote:
On 05/07/2023 02:04, Marek Vasut wrote:
From: Isai Gaspar <isaiezequiel.gaspar@xxxxxxx>

The PCA995x chips are I2C controlled LED drivers. Each chip has
up to 16 outputs, each one with an individual 8-bit resolution
PWM for brightness control.

Signed-off-by: Isai Gaspar <isaiezequiel.gaspar@xxxxxxx>
Signed-off-by: Marek Vasut <marex@xxxxxxx> # Basically rewrite the driver

...

+
+static struct i2c_driver pca995x_driver = {
+	.driver = {
+		.name = "leds-pca995x",
+		.owner = THIS_MODULE,
+		.of_match_table = of_match_ptr(pca995x_of_match),

Drop of_match_ptr(), it will cause warnings and is not really helpful.

Will do , thanks.

I'll wait for the bindings review before sending V3.



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux