On Wed, 5 Jul 2023 17:44:05 +0200 Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > On 05/07/2023 17:34, Hugo Villeneuve wrote: > > On Wed, 5 Jul 2023 12:22:55 -0300 > > Fabio Estevam <festevam@xxxxxxxxx> wrote: > > > >> Hi Hugo, > >> > >> On Wed, Jul 5, 2023 at 11:48 AM Hugo Villeneuve <hugo@xxxxxxxxxxx> wrote: > >> > >>> Fabio: do we need to support both configurations in the Linux kernel > >>> tree, and if yes how do you propose we do it? > >> > >> I would suggest supporting the new revision only. > > > > Ok, no problem. > > > > If we go back to my original patch, the changes in it, apart from the > > interrupt, are still required to make USB OTG work (at least in host > > mode, so that we can plug a USB key for example). Also looking at the > > latest varigit changes, I have removed the "typec1_con: > > connector" node (tested ok in host mode). I also added comments in the > > DTS about the particular PTN5150 interrupt pin configurations. > > > > Let me know if I can resubmit it, and if so can I leave the interrupt > > property type to IRQ_TYPE_NONE? > > As I wrote, interrupt type cannot be none. What does it even mean "none" > for your case? Hi, I have no idea why Variscite are using this IRQ type of NONE. I can put IRQ_TYPE_EDGE_FALLING since I tested it and it works. Hugo.