On 05/07/2023 05:37, William Qiu wrote: >>> --- >>> Documentation/devicetree/bindings/spi/spi-pl022.yaml | 11 ++++++++--- >>> 1 file changed, 8 insertions(+), 3 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml >>> index 91e540a92faf..42bb34c39971 100644 >>> --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml >>> +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml >>> @@ -11,6 +11,7 @@ maintainers: >>> >>> allOf: >>> - $ref: spi-controller.yaml# >>> + - $ref: /schemas/arm/primecell.yaml# >> >> This looks unrelated, so keep it as separate commit with its own rationale. >> > Because "arm,primecell-periphid" is need in JH7110 SoC, so I added them in > one commit, so do I need to put them in two commit? You need to provide rationale why this is needed. I would assume this is needed for every primecell, not only JH7110, right? Best regards, Krzysztof
