Re: [PATCH] [RFC] dt-bindings: leds: bd2606mvv: Fix maximum register value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marek,

you are right.

Reviewed-by: Andreas Kemnade <andreas@xxxxxxxxxxxx>

On Tue,  4 Jul 2023 22:29:29 +0200
Marek Vasut <marex@xxxxxxx> wrote:

> Since the chip can drive up to 6 lines, the maximum
> register number should be only 5, not 6.
> 
> Signed-off-by: Marek Vasut <marex@xxxxxxx>
> ---
> Cc: Andreas Kemnade <andreas@xxxxxxxxxxxx>
> Cc: Conor Dooley <conor+dt@xxxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>
> Cc: Lee Jones <lee@xxxxxxxxxx>
> Cc: Pavel Machek <pavel@xxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Cc: linux-leds@xxxxxxxxxxxxxxx
> ---
>  Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml b/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml
> index 14700a2e5feaa..44dd91aa239de 100644
> --- a/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml
> +++ b/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml
> @@ -35,7 +35,7 @@ properties:
>      description: GPIO pin to enable/disable the device.
>  
>  patternProperties:
> -  "^led@[0-6]$":
> +  "^led@[0-5]$":
>      type: object
>      $ref: common.yaml#
>      unevaluatedProperties: false
> @@ -43,7 +43,7 @@ patternProperties:
>      properties:
>        reg:
>          minimum: 0
> -        maximum: 6
> +        maximum: 5
>  
>      required:
>        - reg




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux