On 04/07/2023 17:31, Hugo Villeneuve wrote: > On Tue, 4 Jul 2023 17:08:12 +0200 > Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > >> On 04/07/2023 17:02, Hugo Villeneuve wrote: >>> From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx> >>> >>> USB OTG is currently broken on the Variscite Symphony EVK and imx8mn >>> nano SOM. >>> >>> Import changes from linux-5.15 branch of doen't giveto fix it. >>> >>> Link: https://github.com/varigit/linux-imx.git >>> Fixes: 7358e05bddca ("arm64: dts: imx8mn-var-som-symphony: Add Variscite Symphony board with VAR-SOM-MX8MN") >>> Signed-off-by: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx> >>> --- >>> .../dts/freescale/imx8mn-var-som-symphony.dts | 37 ++++++++++++++++++- >>> 1 file changed, 35 insertions(+), 2 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dts b/arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dts >>> index 406a711486da..aef89198f24c 100644 >>> --- a/arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dts >>> +++ b/arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dts >>> @@ -6,6 +6,7 @@ >>> >>> /dts-v1/; >>> >>> +#include <dt-bindings/usb/pd.h> >>> #include "imx8mn-var-som.dtsi" >>> >>> / { >>> @@ -104,10 +105,29 @@ extcon_usbotg1: typec@3d { >>> compatible = "nxp,ptn5150"; >>> reg = <0x3d>; >>> interrupt-parent = <&gpio1>; >>> - interrupts = <11 IRQ_TYPE_LEVEL_LOW>; >>> + interrupts = <11 IRQ_TYPE_NONE>; >> >> That's surprising, why? > > Hi, > the varigit repos log or source code has no information about this > particular configuration. > > In the schematics, the interrupt output pin of the PTN5150 is connected > to two different resistors, one of these being connected to GPIO1 pin > 11. But these two resistors are not assembled on any versions of the > board, so the interrupt pin is currently not used. OK, so there is no interrupt, but not interrupt of type none. Just drop the property and make it optional in the bindings. The driver however requires the interrupt, so I wonder how the device is going to work without it? Are you sure that interrupt line is not shorted instead of missing resistor? Best regards, Krzysztof
