On 04/07/2023 07:39, Shengjiu Wang wrote: > Add the clock dt-binding file for audio clock mux. which > is the IP for i.MX8QM, i.MX8QXP, i.MX8DXL. > > Signed-off-by: Shengjiu Wang <shengjiu.wang@xxxxxxx> Except what the bot already pointed out: > --- > .../devicetree/bindings/clock/imx8-acm.yaml | 71 +++++++++++++++++++ > 1 file changed, 71 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/imx8-acm.yaml > > diff --git a/Documentation/devicetree/bindings/clock/imx8-acm.yaml b/Documentation/devicetree/bindings/clock/imx8-acm.yaml > new file mode 100644 > index 000000000000..820c06b81aa6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/imx8-acm.yaml Filename matching compatible. At least vendor prefix is missing. > @@ -0,0 +1,71 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/imx8-acm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX8 Audio Clock Mux Binding > + > +maintainers: > + - Shengjiu Wang <shengjiu.wang@xxxxxxx> > + > +description: | > + NXP i.MX8 Audio Clock Mux is dedicated clock muxing IP > + used to control Audio related clock on the SoC. > + > +properties: > + compatible: > + enum: > + - nxp,imx8qm-acm > + - nxp,imx8qxp-acm > + - nxp,imx8dxl-acm > + > + reg: > + maxItems: 1 > + > + power-domains: > + minItems: 13 > + maxItems: 21 21 power domains? What's this? Why clock device make entire SoC awake? Anyway, you need to list them. > + > + '#clock-cells': > + const: 1 > + description: > + The clock consumer should specify the desired clock by having the clock > + ID in its "clocks" phandle cell. See include/dt-bindings/clock/imx8-clock.h > + for the full list of i.MX8 ACM clock IDs. > + > +required: > + - compatible > + - reg > + - power-domains > + - '#clock-cells' > + > +additionalProperties: false > + > +examples: > + # Clock Control Module node: > + - | > + #include <dt-bindings/firmware/imx/rsrc.h> > + > + acm@59e00000 { Node names should be generic. See also explanation and list of examples in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "nxp,imx8qxp-acm"; > + reg = <0x59e00000 0x1D0000>; Don't mix hexes. Only lower-case. Please perform some basic review in NXP before sending it. Best regards, Krzysztof
