On 03/07/2023 16:38, Konrad Dybcio wrote:
> On 3.07.2023 16:01, Krzysztof Kozlowski wrote:
>> On 03/07/2023 15:31, Konrad Dybcio wrote:
>>> Some SoCs (like SM8150 and SM8250) don't seem to provide a qup-core path.
>>> Allow such case.
>>>
>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
>>> ---
>>> .../bindings/serial/qcom,serial-geni-qcom.yaml | 26 +++++++++++++++-------
>>> 1 file changed, 18 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml b/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml
>>> index dd33794b3534..a0acba57bc06 100644
>>> --- a/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml
>>> +++ b/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml
>>> @@ -25,14 +25,6 @@ properties:
>>> clock-names:
>>> const: se
>>>
>>> - interconnects:
>>> - maxItems: 2
>>> -
>>> - interconnect-names:
>>> - items:
>>> - - const: qup-core
>>> - - const: qup-config
>>
>> Instead please keep the definition of the fields in top-level properties
>> with the widest constraints, e.g.
>> interconnects:
>> minItems: 1
>> maxItems: 2
>>
>> interconnect-names:
>> minItems: 1
>> items:
>> - const: qup-core
>> - const: qup-config
> Sadly the issue here is that the qup-config path exists, but qup-core
> doesn't.
Ah, right, then:
interconnect-names:
oneOf:
- items:
....
- items:
...
Best regards,
Krzysztof
