From: Matt Johnston <matt@xxxxxxxxxxxxxxxxxxxx>
Date: Mon, 3 Jul 2023 13:30:48 +0800
> +static void mctp_i3c_xmit(struct mctp_i3c_bus *mbus, struct sk_buff *skb)
> +{
> + struct net_device_stats *stats = &mbus->ndev->stats;
> + struct i3c_priv_xfer xfer = { .rnw = false };
> + struct mctp_i3c_internal_hdr *ihdr = NULL;
> + struct mctp_i3c_device *mi = NULL;
> + u8 *data = NULL;
> + unsigned int data_len;
> + u8 addr, pec;
> + int rc = 0;
> + u64 pid;
...
> +/* Returns an ERR_PTR on failure */
> +static struct mctp_i3c_bus *mctp_i3c_bus_add(struct i3c_bus *bus)
> +__must_hold(&busdevs_lock)
> +{
> + struct mctp_i3c_bus *mbus = NULL;
> + struct net_device *ndev = NULL;
> + u8 addr[PID_SIZE];
> + char namebuf[IFNAMSIZ];
> + int rc;
Please order local variables from longest to shortest line.
Please do this for your entire submission.
Thank you.
