On Mon, Jul 03, 2023 at 11:30:24AM +0200, Konrad Dybcio wrote: > On 2.07.2023 20:50, Krzysztof Kozlowski wrote: > > The DTS code coding style expects exactly one space before and after '=' > > sign. > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > --- [...] > > diff --git a/arch/arm64/boot/dts/qcom/msm8939.dtsi b/arch/arm64/boot/dts/qcom/msm8939.dtsi > > index 895cafc11480..c4209e2d4b4e 100644 > > --- a/arch/arm64/boot/dts/qcom/msm8939.dtsi > > +++ b/arch/arm64/boot/dts/qcom/msm8939.dtsi > > @@ -155,7 +155,7 @@ CPU7: cpu@3 { > > > > idle-states { > > CPU_SLEEP_0: cpu-sleep-0 { > > - compatible ="qcom,idle-state-spc", "arm,idle-state"; > > + compatible = "qcom,idle-state-spc", "arm,idle-state"; > Will conflict with: > > https://lore.kernel.org/linux-arm-msm/20230627-topic-more_bindings-v1-2-6b4b6cd081e5@xxxxxxxxxx/ > > there are also a couple of entries with property =\n\t{n}[a-z] > > Otherwise lgtm Konrad, please remember to trim irrelevant context from your replies (e.g. so that we don't have to skim through thousands of lines to find a single comment). Johan