On Tue, 18 Apr 2023 19:03:41 +0200, Nikita Bondarenko wrote: > Converted txt file to yaml. No additional changes. > > Signed-off-by: Nikita Bondarenko <n2h9z4@xxxxxxxxx> > --- > > Changes in v3: > - updated commit message > - updated the compatible definition to probably fix "compatible is too long" warning > - updated example to how it was in the txt file > > > I do not have this warning when I am running > make DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/brcm,kona-wdt.yaml ARCH=arm dt_binding_check > maybe I run it without some additional variable? > > But I checked arch/arm/boot/dts/bcm28155-ap.dts, it includes bcm11351.dtsiv which contains > compatible = "brcm,bcm11351-wdt", "brcm,kona-wdt"; > which probably causes a warning > This is exact how it was in txt file example. > > If I put it in an example in a yaml file, dt_binding_check does not pass. > Looks like the issue is in the enum type of compatible. It does not allow multiple strings. > Updated to not to use enum. The example with two strings in compatible passes the checks. > > make DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/brcm,kona-wdt.yaml ARCH=arm dt_binding_check > LINT Documentation/devicetree/bindings > CHKDT Documentation/devicetree/bindings/processed-schema.json > SCHEMA Documentation/devicetree/bindings/processed-schema.json > DTEX Documentation/devicetree/bindings/watchdog/brcm,kona-wdt.example.dts > DTC_CHK Documentation/devicetree/bindings/watchdog/brcm,kona-wdt.example.dtb > > make DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/brcm,kona-wdt.yaml ARCH=arm dtbs_check > LINT Documentation/devicetree/bindings > CHKDT Documentation/devicetree/bindings/processed-schema.json > SCHEMA Documentation/devicetree/bindings/processed-schema.json > > > v2 patch is here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230402135555.62507-1-n2h9z4@xxxxxxxxx/ > > .../bindings/watchdog/brcm,kona-wdt.txt | 15 ------- > .../bindings/watchdog/brcm,kona-wdt.yaml | 41 +++++++++++++++++++ > 2 files changed, 41 insertions(+), 15 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/watchdog/brcm,kona-wdt.txt > create mode 100644 Documentation/devicetree/bindings/watchdog/brcm,kona-wdt.yaml > Applied, thanks!
