On Mon, 26 Jun 2023 17:33:57 +0200, Krzysztof Kozlowski wrote: > On 26/06/2023 13:09, Hal Feng wrote: >> Add a dummy transmitter driver for StarFive JH7110 PWM-DAC module. >> StarFive JH7110 PWM-DAC controller uses this driver. >> >> Signed-off-by: Hal Feng <hal.feng@xxxxxxxxxxxxxxxx> >> --- >> sound/soc/codecs/Kconfig | 4 ++ >> sound/soc/codecs/Makefile | 2 + >> sound/soc/codecs/jh7110_pwmdac_transmitter.c | 74 ++++++++++++++++++++ >> 3 files changed, 80 insertions(+) >> create mode 100644 sound/soc/codecs/jh7110_pwmdac_transmitter.c >> > > ... > >> + >> +static struct platform_driver pwmdac_dit_driver = { >> + .probe = pwmdac_dit_probe, >> + .driver = { >> + .name = DRV_NAME, >> + .of_match_table = of_match_ptr(pwmdac_dit_dt_ids), >> + }, >> +}; >> + >> +module_platform_driver(pwmdac_dit_driver); >> + >> +MODULE_DESCRIPTION("StarFive JH7110 dummy PWM-DAC transmitter driver"); >> +MODULE_LICENSE("GPL"); >> +MODULE_ALIAS("platform:" DRV_NAME); > > Drop. You don't need it. If you need it, it means you miss proper ID table. OK. I will drop it in the next version. Thanks. Best regards, Hal