Hi Jiri,
On Tue, Jun 27, 2023 at 08:53:16AM +0200, Jiri Valek - 2N wrote:
> @@ -439,7 +589,7 @@ static int cap11xx_i2c_probe(struct i2c_client *i2c_client)
> priv->idev->id.bustype = BUS_I2C;
> priv->idev->evbit[0] = BIT_MASK(EV_KEY);
>
> - if (of_property_read_bool(node, "autorepeat"))
> + if (of_property_read_bool(dev->of_node, "autorepeat"))
It would be good to have this driver switched from of_property_*() to
device_property_() API.
> __set_bit(EV_REP, priv->idev->evbit);
>
> for (i = 0; i < cap->num_channels; i++)
> @@ -474,14 +624,8 @@ static int cap11xx_i2c_probe(struct i2c_client *i2c_client)
> if (error)
> return error;
>
> - irq = irq_of_parse_and_map(node, 0);
> - if (!irq) {
> - dev_err(dev, "Unable to parse or map IRQ\n");
> - return -ENXIO;
> - }
> -
> - error = devm_request_threaded_irq(dev, irq, NULL, cap11xx_thread_func,
> - IRQF_ONESHOT, dev_name(dev), priv);
> + error = devm_request_threaded_irq(dev, i2c_client->irq, NULL,
> + cap11xx_thread_func, IRQF_ONESHOT, dev_name(dev), priv);
I would prefer this change be a separate patch.
Thanks.
--
Dmitry
