Re: [PATCH v4 18/21] pinctrl: qcom: Use qcom_scm_io_update_field()

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Wed, Jun 28, 2023 at 3:37 PM Mukesh Ojha <quic_mojha@xxxxxxxxxxx> wrote:
>
> Use qcom_scm_io_update_field() exported function introduced
> in last commit.

the last

But what is that? Be more specific.

...

> +       mask = (GENMASK(2, 0) << g->intr_target_bit);

Outer parentheses are not needed.

-- 
With Best Regards,
Andy Shevchenko