On 26/06/2023 13:32, Luca Weiss wrote: > Hi Krzysztof, > > On Wed Jun 21, 2023 at 4:36 PM CEST, Krzysztof Kozlowski wrote: >> SM8350 HDK and MTP boards were silently dying and rebooting during BAM >> DMA probe: >> >> [ 1.574304] vreg_bob: Setting 3008000-3960000uV >> [ 1.576918] bam-dFormat: Log Type - Time(microsec) - Message - >> Optional Info >> Log Type: B - Since Boot(Power On Reset), D - Delta, S - Statistic >> S - QC_IMAGE_VERSION_STRING=BOOT.MXF.1.0-00637.1-LAHAINA-1 >> S - IMAGE_VARIANT_STRING=SocLahainaLAA >> S - OEM_IMAGE_VERSION_STRING=crm-ubuntu77 >> S - Boot Interface: UFS >> >> It seems that BAM DMA is locally controller (not by firmware) and >> requires proper initialization by the driver prior to use, at least on >> HDK8350 and MTP8350, but probably on all boards. > > Are you sure that the bam (and subsequent the qce) actually probes with > this change? From reading the code I don't see how the bam should probe > without either qcom,controlled-remotely or qcom,powered-remotely but no Why the binding does not require either this or that? Eh, buggy stuff... > clocks supplied. I think the probe just fails with this change, right? I will need to double check. I was happy enough to be able to boot my device instead of having crashes, but indeed it would be nice to fix it fully. Best regards, Krzysztof