On 26/06/2023 11:02, Komal Bajaj wrote: > > > On 6/26/2023 2:00 PM, Krzysztof Kozlowski wrote: >> On 26/06/2023 10:22, Komal Bajaj wrote: >>>>> + >>>>> +allOf: >>>>> + - $ref: nvmem.yaml# >>>>> + >>>>> +properties: >>>>> + compatible: >>>>> + items: >>>>> + - enum: >>>>> + - qcom,qdu1000-sec-qfprom >>>>> + - const: qcom,sec-qfprom >>>>> + >>>>> + reg: >>>>> + items: >>>>> + - description: The secure qfprom corrected region. >>>>> + >>>>> + # Needed if any child nodes are present. >>>>> + "#address-cells": >>>>> + const: 1 >>>>> + "#size-cells": >>>>> + const: 1 >>>> Drop both, they are not needed. >>> I didn't get it. Can you please explain why these are not needed as this >>> node will have child nodes which will use single value for address and size. >> I suspect they are already defined. Do other bindings (for cases with >> children) have them? If not, why here it would be different? > > Yes, I see there are bindings that has these properties, listed a few of > them below - > > [1] > https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml Please work on current development. It's a bit of waste of time to review old code... https://lore.kernel.org/all/20230611140330.154222-16-srinivas.kandagatla@xxxxxxxxxx/ > [2] > https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/firmware/arm,scmi.yaml That's not a nvmem provider. > [3] > https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml That's not a nvmem provider. Best regards, Krzysztof
