On Wed, Jun 7, 2023 at 10:16 PM Dmitry Rokosov <ddrokosov@xxxxxxxxxxxxxx> wrote: > > From: Jan Dakinevich <yvdakinevich@xxxxxxxxxxxxxx> > > The definition is inspired by a similar one for AXG SoC family. > 'sdio_pins' and 'sdio_clk_gate_pins' pinctrls are supposed to be used as > "default" and "clk-gate" in board-specific device trees. Let's wait for Neil's response on the other patch for the question about pin mux settings > 'meson-gx' driver during initialization sets clock to safe low-frequency > value (400kHz). However, both source clocks ("clkin0" and "clkin1") are > high-frequency by default, and using of eMMC's internal divider is not > enough to achieve so low values. To provide low-frequency source, > reparent "sd_emmc_sel2" clock using 'assigned-clocks' property. Even if the pinctrl part should be postponed then I think it's worth adding &sd_emmc