On 23/06/2023 14:33, Krzysztof Kozlowski wrote: > On 23/06/2023 13:30, Abel Vesa wrote: >> Add the compatible string for the UFS on sm6115 and sm6125 platforms. >> >> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx> >> --- >> .../devicetree/bindings/ufs/qcom,ufs.yaml | 32 +++++++++++++++++++ >> 1 file changed, 32 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> index bdfa86a0cc98..46f454ec3688 100644 >> --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> @@ -29,6 +29,8 @@ properties: >> - qcom,sa8775p-ufshc >> - qcom,sc8280xp-ufshc >> - qcom,sdm845-ufshc >> + - qcom,sm6115-ufshc >> + - qcom,sm6125-ufshc >> - qcom,sm6350-ufshc >> - qcom,sm8150-ufshc >> - qcom,sm8250-ufshc >> @@ -163,6 +165,36 @@ allOf: >> minItems: 2 >> maxItems: 2 >> >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - qcom,sm6115-ufshc >> + - qcom,sm6125-ufshc >> + then: >> + properties: >> + clocks: >> + minItems: 8 >> + maxItems: 8 >> + clock-names: >> + items: >> + - const: core_clk >> + - const: bus_aggr_clk >> + - const: iface_clk >> + - const: core_clk_unipro >> + - const: ref_clk >> + - const: tx_lane0_sync_clk >> + - const: rx_lane0_sync_clk >> + - const: ice_core_clk >> + reg: >> + minItems: 2 >> + maxItems: 2 >> + reg-names: >> + items: >> + - const: std >> + - const: ice > > Same comment about reg-names as for your further patch. > > I guess this will supersed the > https://lore.kernel.org/all/20221215190404.398788-1-they@xxxxxxxxx/ > (because it was abandoned... I keep rebasing this patch for half a year) > The 6115 is even older - from October: https://lore.kernel.org/all/20221030094258.486428-2-iskren.chernev@xxxxxxxxx/ Let's go with your patch, but you anyway need to fix reg-names. Best regards, Krzysztof
