> -----Original Message-----
> From: Conor Dooley <conor@xxxxxxxxxx>
> Sent: Friday, 23 June, 2023 3:19 AM
> To: Lee, Kah Jing <kah.jing.lee@xxxxxxxxx>
> Cc: Dinh Nguyen <dinguyen@xxxxxxxxxx>; Rob Herring
> <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>;
> Catalin Marinas <catalin.marinas@xxxxxxx>; Will Deacon <will@xxxxxxxxxx>;
> linux-kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Yuslaimi, Alif
> Zakuan <alif.zakuan.yuslaimi@xxxxxxxxx>
> Subject: Re: [PATCH 1/2] arch: arm64: boot: dts: Updated QSPI Flash layout
> for UBIFS
>
> On Thu, Jun 22, 2023 at 04:53:19PM +0800, kah.jing.lee@xxxxxxxxx wrote:
> > From: Alif Zakuan Yuslaimi <alif.zakuan.yuslaimi@xxxxxxxxx>
> >
> > This patch is to update the QSPI flash layout to support UBIFS in mtd
> > root partition.
>
> That much is clear from the diff. Surely it'd be better to explain *why* this
> change is being made, no?
Updated in v3 - Commit message:
Update the QSPI flash layout to support UBIFS in mtd root partition.
Flash layout is updated in order to store non-UBIFS related boot and fpga data in
qspi_boot(mtd0) while keep the rootfs with UBIFS in the root partition(mtd1).
>
> Thanks,
> Conor.
>
> >
> > Signed-off-by: Alif Zakuan Yuslaimi <alif.zakuan.yuslaimi@xxxxxxxxx>
> > Signed-off-by: Kah Jing Lee <kah.jing.lee@xxxxxxxxx>
> > ---
> > arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 8 ++++----
> > arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts | 8 ++++----
> > 2 files changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> > b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> > index 38ae674f2f02..12b960b9183c 100644
> > --- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> > +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> > @@ -202,12 +202,12 @@ partitions {
> >
> > qspi_boot: partition@0 {
> > label = "Boot and fpga data";
> > - reg = <0x0 0x03FE0000>;
> > + reg = <0x0 0x04200000>;
> > };
> >
> > - qspi_rootfs: partition@3FE0000 {
> > - label = "Root Filesystem - JFFS2";
> > - reg = <0x03FE0000 0x0C020000>;
> > + root: partition@4200000 {
> > + label = "Root Filesystem - UBIFS";
> > + reg = <0x04200000 0x0BE00000>;
> > };
> > };
> > };
> > diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
> > b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
> > index 07c3f8876613..608017e6e36a 100644
> > --- a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
> > +++ b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
> > @@ -128,12 +128,12 @@ partitions {
> >
> > qspi_boot: partition@0 {
> > label = "Boot and fpga data";
> > - reg = <0x0 0x03FE0000>;
> > + reg = <0x0 0x04200000>;
> > };
> >
> > - qspi_rootfs: partition@3FE0000 {
> > - label = "Root Filesystem - JFFS2";
> > - reg = <0x03FE0000 0x0C020000>;
> > + root: partition@4200000 {
> > + label = "Root Filesystem - UBIFS";
> > + reg = <0x04200000 0x0BE00000>;
> > };
> > };
> > };
> > --
> > 2.25.1
> >
Thanks.
Regards,
Lee, Kah Jing
