On 23/06/2023 07:45, Varadarajan Narayanan wrote: > >>> + >>> +description: >>> + USB M31 PHY found in Qualcomm IPQ5018, IPQ5332 SoCs. >> >> Where's the IPQ5018 compatible? > > In the previous version had a default and IPQ5332 specific > compatible. IPQ5018 would have used the default compatible. > However, in the review was asked to drop the default compatible. > Hence planned to include ipq5018 compatible and post it in > separate patchset while enabling IPQ5018 USB. IPQ5018 init is > also diffferent from the init used here. Your previous patch did not have ipq5018 compatible. There was nothing indicating that some default means ipq5018... Best regards, Krzysztof