On Thu, Jun 22, 2023 at 07:29:54PM +0530, Praveen Talari wrote: > Add a property to configure QUPv3 SE as SPI Device mode. > > Signed-off-by: Praveen Talari <quic_ptalari@xxxxxxxxxxx> > --- > v2 -> v3: > - modified commit message to use device mode instead of slave mode Suitability or w/e of the property aside, I don't understand this. Why not change the *property*, which has far more visibility than the commit message, to use device rather than slave? Chers, Conor. > --- > Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml > index 2e20ca313ec1..5c7d0293bbf7 100644 > --- a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml > +++ b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml > @@ -66,6 +66,10 @@ properties: > reg: > maxItems: 1 > > + qcom,slv-ctrl: > + description: configure QUPv3 SE as Device mode > + type: boolean > + > required: > - compatible > - clocks > -- > 2.17.1 >
Attachment:
signature.asc
Description: PGP signature
