On Wed, Jun 21, 2023 at 7:12 PM Conor Dooley <conor@xxxxxxxxxx> wrote: > > Lucas, > > On Wed, Jun 21, 2023 at 03:53:04PM +0200, Krzysztof Kozlowski wrote: > > On 21/06/2023 15:32, Lucas Tanure wrote: > > > Amlogic T7 SoCs uses the same UART controller as S4 SoCs and G12A. > > > There is no need for an extra compatible line in the driver, but > > > add T7 compatible line for documentation. > > > > > > Signed-off-by: Lucas Tanure <tanure@xxxxxxxxx> > > > --- > > > .../devicetree/bindings/serial/amlogic,meson-uart.yaml | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml > > > index 01ec45b3b406..860ab58d87b0 100644 > > > --- a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml > > > +++ b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml > > > @@ -33,6 +33,7 @@ properties: > > > - amlogic,meson8b-uart > > > - amlogic,meson-gx-uart > > > - amlogic,meson-s4-uart > > > + - amlogic,meson-t7-uart > > > - const: amlogic,meson-ao-uart > > > - description: Always-on power domain UART controller on G12A SoCs > > > items: > > > @@ -46,6 +47,7 @@ properties: > > > - amlogic,meson8b-uart > > > - amlogic,meson-gx-uart > > > - amlogic,meson-s4-uart > > > + - amlogic,meson-t7-uart > > > > It does not look like you tested the DTS against bindings. Please run > > `make dtbs_check` (see > > Documentation/devicetree/bindings/writing-schema.rst or > > https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ > > for instructions). > > Check back on the previous version, I should've posted an untested > version of what you need to add. I saw that, but adding a S4 doesn't make sense to me. And you didn't show the entire change, so I can't understand what you want there. > > Cheers, > Conor.
