On Mon, Jun 12, 2023 at 11:33:15AM +0200, Uwe Kleine-König wrote:
> Hello,
>
> On Fri, Jun 09, 2023 at 04:07:09PM +0200, Krzysztof Kozlowski wrote:
> > Cleanup bindings dropping unneeded quotes. Once all these are fixed,
> > checking for this can be enabled in yamllint.
>
> in my book quoting everything instead of dropping quotes is the better
> option. While that policy adds more quotes, it prevents surprises like:
>
> $ yaml2json << EOF
> > countrycodes:
> > - de
> > - fr
> > - no
> > - pl
> > EOF
> {
> "countrycodes": [
> "de",
> "fr",
> false,
> "pl"
> ]
> }
>
> And if you use the "only-when-needed" rule of yamllint you have to write
> the above list as:
>
> countrycodes:
> - de
> - fr
> - "no"
> - pl
>
> which is IMHO really ugly.
Agreed, but "no" and "yes" are unlikely values in DT.
>
> Another culprit is "on" (which is used e.g. in github action workflows),
> so yamllint tells for example for
> https://github.com/pengutronix/microcom/blob/main/.github/workflows/build.yml:
>
> 3:1 warning truthy value should be one of [false, true] (truthy)
>
> and there are still more surprises (e.g. version numbers might be
> subject to conversion to float).
I'll add a meta-schema check for this. 'const' is already limited to
string or integer. That's missing from 'enum'. I think we can also check
that all items are the same type as well.
> So at least in my bubble the general
> hint is to *always* quote strings. Note that required: true is also the
> default for yamllint's quoted-strings setting, proably for pitfalls like
> these.
We're so far gone the other direction from quoting everything, that's
not going to happen. Plus, if I liked everything quoted, I would have
used JSON.
My preference here is I don't want to care about this in reviews. I want
yamllint to check it and not have to think about it again.
Rob
