On Wed, Jun 21, 2023 at 05:45:05PM +0200, Benjamin Bara wrote: > Hi, > > thanks for the feedback! > > On Wed, 21 Jun 2023 at 16:57, Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote: > > On Wed, Jun 21, 2023 at 04:26:27PM +0200, Benjamin Bara wrote: > > > + hub->supplies_num = 1; > > > + if (hub->pdata->supplies_num > 1) > > > + hub->supplies_num = hub->pdata->supplies_num; > > > > Please change the above to: > > > > if (hub->pdata->supplies_num != 0) > > hub->supplies_num = hub->pdata->supplies_num; > > else > > hub->supplies_num = 1; > > > > I would even prefer: > if (hub->pdata->supplies_num) > > if it's fine for you? Sounds good to me :)
