Re: [PATCH v4 13/14] drm/mediatek: Sort OVL adaptor components in alphabetical order

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Il 21/06/23 11:16, Shawn Sung (宋孝謙) ha scritto:
On Wed, 2023-06-21 at 10:16 +0200, AngeloGioacchino Del Regno wrote:
  	
External email : Please do not click links or open attachments until
you have verified the sender or the content.
  Il 21/06/23 05:19, Hsiao Chien Sung ha scritto:
- Rename OVL_ADAPTOR_TYPE_RDMA to OVL_ADAPTOR_TYPE_MDP_RDMA
    to align the naming rule of mtk_ovl_adaptor_comp_id.
- Sort components' names in alphabetical order
- Sort device table in alphabetical order
- Add sentinel to device table

Signed-off-by: Hsiao Chien Sung <shawn.sung@xxxxxxxxxxxx>

I agree, but this commit should come before [12/14] of this series.

Got it. Since [12/14] removed many lines that use component ID/type
(for example, in mtk_ovl_adaptor_clk_enable() or
mtk_ovl_adaptor_add_comp()), if this commit has to move before that,
should I still modify them and delete them in [12/14]? Thanks.


Every commit has to work on its own, so you first perform the renaming in
one commit, then you modify and delete.



Regards,
Angelo


Best regards,
Hsiao Chien Sung




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux