Hello Krzysztof > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Sent: Tuesday, June 20, 2023 3:55 PM > To: ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開) > <yuji2.ishikawa@xxxxxxxxxxxxx>; Hans Verkuil <hverkuil@xxxxxxxxx>; Sakari > Ailus <sakari.ailus@xxxxxx>; Laurent Pinchart > <laurent.pinchart@xxxxxxxxxxxxxxxx>; Mauro Carvalho Chehab > <mchehab@xxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof > Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley > <conor+dt@xxxxxxxxxx>; iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○ > ＯＳＴ) <nobuhiro1.iwamatsu@xxxxxxxxxxxxx> > Cc: linux-media@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v6 1/5] dt-bindings: media: platform: visconti: Add Toshiba > Visconti Video Input Interface bindings > > On 20/06/2023 05:11, Yuji Ishikawa wrote: > > Adds the Device Tree binding documentation that allows to describe the > > Video Input Interface found in Toshiba Visconti SoCs. > > > > Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@xxxxxxxxxxxxx> > > Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@xxxxxxxxxxxxx> > > --- > > Changelog v2: > > - no change > > > > Changelog v3: > > - no change > > > > Changelog v4: > > - fix style problems at the v3 patch > > - remove "index" member > > - update example > > > > Changelog v5: > > - no change > > > > Changelog v6: > > - add register definition of BUS-IF and MPU > > You ignored the comments from v4->v5. I pointed this out. You still ignored > them. > > You keep sending the same wrong patch ignoring review. This is not acceptable. > > NAK I'm sorry for forgetting applying advice for v4 and v5 patches to this submission. I'll add following changes to the v7 patch. * Remove trailing "bindings" at the commit header, as "dt-bindings:" is already set. * Remove trailing "Device Tree Bindings" from the title. * Fix text wrappings of the description * Update compatible to "toshiba,visconti5-viif" * Update clock-lanes.description "s/line/lane/" * the same with data-lanes.description * remove "unevaluatedProperty:false" from endpoint. put "additionalProperties:false" instead. > Best regards, > Krzysztof Best regards, Yuji Ishikawa
