On Tue, Jun 13, 2023 at 04:34:44PM +0800, Xu Yang wrote: > Convert the binding to DT schema format. Besides, this also add clocks, > '#phy-cells', phy-3p0-supply and power-domains properties which are not > contained in txt file due to txt file lack updates. > > Signed-off-by: Xu Yang <xu.yang_2@xxxxxxx> > > --- > Changes in v2: > - change filename to fsl,mxs-usbphy.yaml > - add other optional properties > - narrow fsl,anatop to imx6 > - use additionalProperties > Changes in v3: > - fix indentation > - add clocks property to example > Changes in v4: > - remove [fsl,imx7ulp-usbphy, fsl,imx6ul-usbphy] > - limit item of reg and interrupts to 1 > - sort enum items > - modify commit message > --- > .../bindings/phy/fsl,mxs-usbphy.yaml | 125 ++++++++++++++++++ > .../devicetree/bindings/phy/mxs-usb-phy.txt | 33 ----- > 2 files changed, 125 insertions(+), 33 deletions(-) > create mode 100644 Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > delete mode 100644 Documentation/devicetree/bindings/phy/mxs-usb-phy.txt This should be applied by the PHY maintainers, but they weren't Cc'ed. > > diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > new file mode 100644 > index 000000000000..cc9f2bc7e6fb > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > @@ -0,0 +1,125 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/fsl,mxs-usbphy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale MXS USB Phy Device > + > +maintainers: > + - Xu Yang <xu.yang_2@xxxxxxx> > + > +properties: > + compatible: > + oneOf: > + - enum: > + - fsl,imx23-usbphy > + - fsl,imx7ulp-usbphy > + - fsl,vf610-usbphy > + - items: > + - enum: > + - fsl,imx28-usbphy > + - fsl,imx6ul-usbphy > + - fsl,imx6sl-usbphy > + - fsl,imx6sx-usbphy > + - fsl,imx6q-usbphy > + - const: fsl,imx23-usbphy > + - items: > + - const: fsl,imx6sll-usbphy > + - const: fsl,imx6ul-usbphy > + - const: fsl,imx23-usbphy > + - items: > + - const: fsl,imx8dxl-usbphy > + - const: fsl,imx7ulp-usbphy > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + '#phy-cells': > + const: 0 > + > + power-domains: > + maxItems: 1 > + > + fsl,anatop: > + description: > + phandle for anatop register, it is only for imx6 SoC series. > + $ref: /schemas/types.yaml#/definitions/phandle > + > + phy-3p0-supply: > + description: > + One of USB PHY's power supply. Can be used to keep a good signal > + quality. > + > + fsl,tx-cal-45-dn-ohms: > + description: > + Resistance (in ohms) of switchable high-speed trimming resistor > + connected in parallel with the 45 ohm resistor that terminates > + the DN output signal. > + minimum: 35 > + maximum: 54 > + default: 45 > + > + fsl,tx-cal-45-dp-ohms: > + description: > + Resistance (in ohms) of switchable high-speed trimming resistor > + connected in parallel with the 45 ohm resistor that terminates > + the DP output signal. > + minimum: 35 > + maximum: 54 > + default: 45 > + > + fsl,tx-d-cal: > + description: > + Current trimming value (as a percentage) of the 17.78 mA TX > + reference current. > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 79 > + maximum: 119 > + default: 100 > + > +required: > + - compatible > + - reg > + - clocks > + > +allOf: > + - if: > + properties: > + compatible: > + oneOf: > + - enum: > + - fsl,imx6q-usbphy > + - fsl,imx6sl-usbphy > + - fsl,imx6sx-usbphy > + - fsl,imx6sll-usbphy > + - fsl,vf610-usbphy > + - items: > + - const: fsl,imx6ul-usbphy > + - const: fsl,imx23-usbphy > + then: > + required: > + - fsl,anatop > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/clock/imx6qdl-clock.h> > + > + usbphy1: usb-phy@20c9000 { > + compatible = "fsl,imx6q-usbphy", "fsl,imx23-usbphy"; > + reg = <0x020c9000 0x1000>; > + clocks = <&clks IMX6QDL_CLK_USBPHY1>; > + interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>; > + fsl,anatop = <&anatop>; > + }; > + > +... > diff --git a/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt b/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt > deleted file mode 100644 > index 70c813b0755f..000000000000 > --- a/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt > +++ /dev/null > @@ -1,33 +0,0 @@ > -* Freescale MXS USB Phy Device > - > -Required properties: > -- compatible: should contain: > - * "fsl,imx23-usbphy" for imx23 and imx28 > - * "fsl,imx6q-usbphy" for imx6dq and imx6dl > - * "fsl,imx6sl-usbphy" for imx6sl > - * "fsl,vf610-usbphy" for Vybrid vf610 > - * "fsl,imx6sx-usbphy" for imx6sx > - * "fsl,imx7ulp-usbphy" for imx7ulp > - * "fsl,imx8dxl-usbphy" for imx8dxl > - "fsl,imx23-usbphy" is still a fallback for other strings > -- reg: Should contain registers location and length > -- interrupts: Should contain phy interrupt > -- fsl,anatop: phandle for anatop register, it is only for imx6 SoC series > - > -Optional properties: > -- fsl,tx-cal-45-dn-ohms: Integer [35-54]. Resistance (in ohms) of switchable > - high-speed trimming resistor connected in parallel with the 45 ohm resistor > - that terminates the DN output signal. Default: 45 > -- fsl,tx-cal-45-dp-ohms: Integer [35-54]. Resistance (in ohms) of switchable > - high-speed trimming resistor connected in parallel with the 45 ohm resistor > - that terminates the DP output signal. Default: 45 > -- fsl,tx-d-cal: Integer [79-119]. Current trimming value (as a percentage) of > - the 17.78mA TX reference current. Default: 100 > - > -Example: > -usbphy1: usb-phy@20c9000 { > - compatible = "fsl,imx6q-usbphy", "fsl,imx23-usbphy"; > - reg = <0x020c9000 0x1000>; > - interrupts = <0 44 0x04>; > - fsl,anatop = <&anatop>; > -}; > -- > 2.34.1 >
