Re: [RFC PATCH v2 3/3] arm64: dts: renesas: ulcb-kf: add node for GPS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wolfram,

On Tue, Jun 20, 2023 at 12:39 PM Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> From: Wolfram Sang <wsa@xxxxxxxxxx>
>
> Add the node for the GPS receiver and its VCC supply.
>
> Signed-off-by: Wolfram Sang <wsa@xxxxxxxxxx>
> ---
> Changes since RFC v1:
> * rebased because of patches dropped and refactored
> * added static vcc-suplly

Thanks for the update!

> @Geert: Not sure if we need so many fixed 3v3 regulators. Most of the
> other ones more or less directly derive from d_3v3. Or do you prefer it
> this way?

Probably all of them should refer to &reg_3p3v instead...

> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> @@ -39,6 +39,13 @@ accel_3v3: regulator-acc-3v3 {
>                 regulator-max-microvolt = <3300000>;
>         };
>
> +       d_3v3: regulator-d-3v3 {

... but if you want to keep it like this for now, please name
it appropriately (s/d/gnss/g).

> +               compatible = "regulator-fixed";
> +               regulator-name = "d-3v3";
> +               regulator-min-microvolt = <3300000>;
> +               regulator-max-microvolt = <3300000>;
> +       };
> +
>         hdmi_1v8: regulator-hdmi-1v8 {
>                 compatible = "regulator-fixed";
>                 regulator-name = "hdmi-1v8";

The rest LGTM.

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux