On 19/06/2023 15:24, Konrad Dybcio wrote: > On 16.06.2023 21:02, Krzysztof Kozlowski wrote: >> Add audio-related nodes: the APR in the ADSP (same as on SM8250) and >> LPASS TLMM pin controller. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> >> --- >> >> Bindings for SM8350: >> https://lore.kernel.org/linux-arm-msm/20230616185742.2250452-1-krzysztof.kozlowski@xxxxxxxxxx/T/#t >> --- >> arch/arm64/boot/dts/qcom/sm8350.dtsi | 82 ++++++++++++++++++++++++++++ >> 1 file changed, 82 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi >> index 33b7ef8fd78a..9650cecb1370 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi >> @@ -15,7 +15,9 @@ >> #include <dt-bindings/mailbox/qcom-ipcc.h> >> #include <dt-bindings/phy/phy-qcom-qmp.h> >> #include <dt-bindings/power/qcom-rpmpd.h> >> +#include <dt-bindings/soc/qcom,apr.h> >> #include <dt-bindings/soc/qcom,rpmh-rsc.h> >> +#include <dt-bindings/sound/qcom,q6afe.h> >> #include <dt-bindings/thermal/thermal.h> >> #include <dt-bindings/interconnect/qcom,sm8350.h> >> >> @@ -1780,6 +1782,20 @@ tcsr_mutex: hwlock@1f40000 { >> #hwlock-cells = <1>; >> }; >> >> + lpass_tlmm: pinctrl@33c0000 { >> + compatible = "qcom,sm8350-lpass-lpi-pinctrl"; >> + reg = <0 0x033c0000 0x0 0x20000>, > '0' for addr, '0x0' for size :/ > > The rest of the file uses '0', please do that It's a mixture but mostly 0x0 in both places. I don't mind switching to 0. > >> + <0 0x03550000 0x0 0x10000>; >> + >> + clocks = <&q6afecc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>, >> + <&q6afecc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>; >> + clock-names = "core", "audio"; >> + >> + gpio-controller; >> + #gpio-cells = <2>; >> + gpio-ranges = <&lpass_tlmm 0 0 15>; >> + }; >> + >> gpu: gpu@3d00000 { >> compatible = "qcom,adreno-660.1", "qcom,adreno"; >> >> @@ -3189,6 +3205,72 @@ IPCC_MPROC_SIGNAL_GLINK_QMP >> label = "lpass"; >> qcom,remote-pid = <2>; >> >> + apr { >> + compatible = "qcom,apr-v2"; >> + qcom,glink-channels = "apr_audio_svc"; >> + qcom,domain = <APR_DOMAIN_ADSP>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + service@3 { >> + reg = <APR_SVC_ADSP_CORE>; >> + compatible = "qcom,q6core"; >> + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; >> + }; >> + >> + q6afe: service@4 { >> + compatible = "qcom,q6afe"; >> + reg = <APR_SVC_AFE>; >> + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; > Missing newline before subnodes acks Best regards, Krzysztof
