On 16/06/2023 17:17, Andy Shevchenko wrote:
On Fri, Jun 16, 2023 at 04:59:15PM +0300, Tomi Valkeinen wrote:
Select GPIOLIB rather than OF_GPIO, as the drivers use gpiolib
functionality, but no of_gpio (directly).
This is useful change, but has to be folded in the original code.
We do not want even a trace of newly added OF_GPIO.
Yes, I think the first three new patches should be squashed:
media: i2c: ds90ub960: Fix use of UB960_SR_FWD_CTL1
media: i2c: ds90ub9xx: Add COMMON_CLK kconfig dependency
media: i2c: ds90ub9xx: Select GPIOLIB rather than OF_GPIO
The rest... Thinking about it now, I should have perhaps left them out,
as they're not fixing issues, and perhaps they just confuse the merging
process.
Tomi
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>
---
drivers/media/i2c/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index 8a5f09a3de6c..29fc00e30d8b 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -1622,7 +1622,7 @@ config VIDEO_DS90UB913
depends on OF && I2C && VIDEO_DEV && COMMON_CLK
select I2C_ATR
select MEDIA_CONTROLLER
- select OF_GPIO
+ select GPIOLIB
select REGMAP_I2C
select V4L2_FWNODE
select VIDEO_V4L2_SUBDEV_API
@@ -1635,7 +1635,7 @@ config VIDEO_DS90UB953
depends on OF && I2C && VIDEO_DEV && COMMON_CLK
select I2C_ATR
select MEDIA_CONTROLLER
- select OF_GPIO
+ select GPIOLIB
select REGMAP_I2C
select V4L2_FWNODE
select VIDEO_V4L2_SUBDEV_API
@@ -1648,7 +1648,7 @@ config VIDEO_DS90UB960
depends on OF && I2C && VIDEO_DEV && COMMON_CLK
select I2C_ATR
select MEDIA_CONTROLLER
- select OF_GPIO
+ select GPIOLIB
select REGMAP_I2C
select V4L2_FWNODE
select VIDEO_V4L2_SUBDEV_API
--
2.34.1
