On 06/06/2023 19:52, Miquel Raynal wrote: > In an effort to constrain as much as we can the existing binding, we > want to add "unevaluatedProperties: false" in all the NAND chip > descriptions part of NAND controller bindings. But in order to do that > properly, we also need to reference a file which contains all the > "allowed" properties. Right now this file is nand-chip.yaml but in > practice raw NAND controllers may use additional properties in their > NAND chip children node. These properties are listed under > nand-controller.yaml, which makes the "unevaluatedProperties" checks > fail while the description are valid. We need to move these NAND chip > related properties into another file, because we do not want to pollute > nand-chip.yaml which is also referenced by eg. SPI-NAND devices. > > Let's create a raw-nand-chip.yaml file to reference all the properties a > raw NAND chip description can contain. The chain of inheritance becomes: > nand-controller.yaml <- raw-nand-chip.yaml > raw-nand-chip.yaml <- nand-chip.yaml > spi-nand.yaml <- nand-chip.yaml ... > - The interpretation of these parameters is implementation-defined, so > - not all implementations must support all possible > - combinations. However, implementations are encouraged to further > - specify the value(s) they support. > - > properties: > $nodename: > pattern: "^nand-controller(@.*)?" > @@ -51,79 +41,8 @@ properties: > > patternProperties: > "^nand@[a-f0-9]$": > - $ref: "nand-chip.yaml#" You work on some old tree, judging by email addresses you CC and by this. I would expect here current next, but this is even pre v6.4-rc1! Working on something older than current master branch doss not make any sense. > - > - properties: > - reg: > - description: > - Contains the chip-select IDs. > - > - nand-ecc-placement: > - description: > - Location of the ECC bytes. This location is unknown by default > - but can be explicitly set to "oob", if all ECC bytes are > - known to be stored in the OOB area, or "interleaved" if ECC > - bytes will be interleaved with regular data in the main area. > - $ref: /schemas/types.yaml#/definitions/string > - enum: [ oob, interleaved ] > - > - nand-bus-width: > - description: > - Bus width to the NAND chip > - $ref: /schemas/types.yaml#/definitions/uint32 > - enum: [8, 16] > - default: 8 > - > - nand-on-flash-bbt: > - description: > - With this property, the OS will search the device for a Bad > - Block Table (BBT). If not found, it will create one, reserve > - a few blocks at the end of the device to store it and update > - it as the device ages. Otherwise, the out-of-band area of a > - few pages of all the blocks will be scanned at boot time to > - find Bad Block Markers (BBM). These markers will help to > - build a volatile BBT in RAM. > - $ref: /schemas/types.yaml#/definitions/flag > - > - nand-ecc-maximize: > - description: > - Whether or not the ECC strength should be maximized. The > - maximum ECC strength is both controller and chip > - dependent. The ECC engine has to select the ECC config > - providing the best strength and taking the OOB area size > - constraint into account. This is particularly useful when > - only the in-band area is used by the upper layers, and you > - want to make your NAND as reliable as possible. > - $ref: /schemas/types.yaml#/definitions/flag > - > - nand-is-boot-medium: > - description: > - Whether or not the NAND chip is a boot medium. Drivers might > - use this information to select ECC algorithms supported by > - the boot ROM or similar restrictions. > - $ref: /schemas/types.yaml#/definitions/flag > - > - nand-rb: > - description: > - Contains the native Ready/Busy IDs. > - $ref: /schemas/types.yaml#/definitions/uint32-array > - > - rb-gpios: > - description: > - Contains one or more GPIO descriptor (the numper of descriptor > - depends on the number of R/B pins exposed by the flash) for the > - Ready/Busy pins. Active state refers to the NAND ready state and > - should be set to GPIOD_ACTIVE_HIGH unless the signal is inverted. > - > - wp-gpios: > - description: > - Contains one GPIO descriptor for the Write Protect pin. > - Active state refers to the NAND Write Protect state and should be > - set to GPIOD_ACTIVE_LOW unless the signal is inverted. > - maxItems: 1 > - > - required: > - - reg > + type: object > + $ref: "raw-nand-chip.yaml#" Again, no quotes. We just removed them everywhere. > Best regards, Krzysztof
