On Sat, Jun 17, 2023 at 06:02:20PM +0100, Conor Dooley wrote: > Hey Jisheng, Hi Conor, > > On Sun, Jun 18, 2023 at 12:15:21AM +0800, Jisheng Zhang wrote: > > Sipeed's Lichee Pi 4A development board uses Lichee Module 4A core > > module which is powered by T-HEAD's TH1520 SoC. Add minimal device > > tree files for the core module and the development board. > > > > Support basic uart/gpio/dmac drivers, so supports booting to a basic > > shell. > > > > NOTE: the thead cpu reset dt-binding and DT node are removed in v3. This > > makes secondary CPUs unable to be online. > > The kernel doesn't do anything with that node though, so if you were to > load a fitImage in U-Boot containing this DT, having booted with > whatever the factory provided OpenSBI has, that limitation doesn't > apply, right? The cpu reset DT node is for opensbi, linux kernel doesn't need it. So you are right: if the u-boot contains the DT node(no matter how the DT node is added, statically added or dynamically added with uboot cmd), the limitation doesn't apply. > > > However, minimal th1520 > > support is better than nothing. And the community has been working on > > and will work on the cpu reset dt-binding, for example, Conor, Guo and > > Jessica are discussing about it, I have seen valuable comments and > > inputs from them. I believe we can add back cpu reset in next > > development window. > > I'll go take a look through this, if it's good I'll apply it and send it > on to Arnd for 6.5? Although I assume it is fine since v2 was nearly Thank you for helping to send out this Pull request! > fine! > > Cheers, > Conor.
