Re: [PATCHv2 1/2] dt-bindings: arm: rockchip: Add Firefly Station P2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 17/06/2023 22:40, Conor Dooley wrote:
> Hey Furkan,
> 
> On Sat, Jun 17, 2023 at 04:53:14PM +0300, Furkan Kardame wrote:
>> Station P2 is a single board computer by firefly based
>> on rk3568 soc
>>
>> Signed-off-by: Furkan Kardame <f.kardame@xxxxxxxxxxx>
>> ---
>>  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> index ec141c937..fa21640bc 100644
>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> @@ -185,6 +185,11 @@ properties:
>>            - const: firefly,rk3566-roc-pc
>>            - const: rockchip,rk3566
>>  
>> +      - description: Firefly Station P2
>> +	items:
>> +	  - const: firefly,rk3568-roc-pc
>> +	  - const: rockchip,rk3568
> 
> yaml files are indented with spaces, not tabs.
> 

Which is pointed out by testing, so this was not tested :(

Please run `make dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Maybe you need to update your dtschema and yamllint.

Best regards,
Krzysztof




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux