On 16/06/2023 17:10, Waqar Hameed wrote: > Murata IRS-D200 is a PIR sensor for human detection. It uses the I2C bus > for communication with interrupt support. Add devicetree bindings > requiring the compatible string, I2C slave address (reg) and interrupts. Thank you for your patch. There is something to discuss/improve. I have actually only remark about DTS example, but since I expect resend two more nits as well. A nit, subject: drop second/last, redundant "bindings for". The "dt-bindings" prefix is already stating that these are bindings. > > Signed-off-by: Waqar Hameed <waqar.hameed@xxxxxxxx> > --- > .../iio/proximity/murata,irsd200.yaml | 54 +++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/proximity/murata,irsd200.yaml > > diff --git a/Documentation/devicetree/bindings/iio/proximity/murata,irsd200.yaml b/Documentation/devicetree/bindings/iio/proximity/murata,irsd200.yaml > new file mode 100644 > index 000000000000..d317fbe7bd50 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/proximity/murata,irsd200.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/proximity/murata,irsd200.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Murata IRS-D200 PIR sensor > + > +maintainers: > + - Waqar Hameed <waqar.hameed@xxxxxxxx> > + > +description: | Nit, do not need '|' unless you need to preserve formatting. > + PIR sensor for human detection. > + > +properties: > + compatible: > + const: murata,irsd200 > + > + reg: > + items: > + - enum: > + - 0x48 > + - 0x49 > + description: | > + When the AD pin is connected to GND, the slave address is 0x48. > + When the AD pin is connected to VDD, the slave address is 0x49. > + > + interrupts: > + maxItems: 1 > + description: > + Type should be IRQ_TYPE_EDGE_RISING. > + > +required: > + - compatible > + - reg > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + pir@48 { Node names should be generic. See also explanation and list of examples in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation so I guess: proximity@? Best regards, Krzysztof
