Re: [PATCH v14 1/2] thermal: loongson-2: add thermal management support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





在 2023/6/17 下午3:15, Daniel Lezcano 写道:
On 17/06/2023 05:25, zhuyinbo wrote:

Hi Daniel,

在 2023/6/12 下午10:22, Daniel Lezcano 写道:

...


+#define LOONGSON2_SOC_MAX_SENSOR_NUM            4
+
+#define LOONGSON2_TSENSOR_CTRL_HI            0x0
+#define LOONGSON2_TSENSOR_CTRL_LO            0x8
+#define LOONGSON2_TSENSOR_STATUS            0x10
+#define LOONGSON2_TSENSOR_OUT                0x14

Please use BIT() macros


I learn about that BIT() is generally used to describe the functional
bit or control bit or status bits of a register, but these register was
some different register offset and not some control bit or status bit
So using BIT() here seems a bit inappropriate, Do you think so?

Yes, you are right


okay, I got it.

Thanks,
Yinbo




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux