On 17/06/2023 08:59, Binbin Zhou wrote: > On Fri, Jun 16, 2023 at 5:59 PM Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: >> >> On 16/06/2023 08:11, Binbin Zhou wrote: >>> Add DeviceTree file for Loongson-2K1000 processor, which integrates two >>> 64-bit dual emission superscalar LA264 processor cores. >>> >>> Signed-off-by: Binbin Zhou <zhoubinbin@xxxxxxxxxxx> >>> --- >>> arch/loongarch/boot/dts/Makefile | 3 +- >>> arch/loongarch/boot/dts/loongson_2k1000.dts | 565 ++++++++++++++++++++ >>> 2 files changed, 567 insertions(+), 1 deletion(-) >>> create mode 100644 arch/loongarch/boot/dts/loongson_2k1000.dts >>> >>> diff --git a/arch/loongarch/boot/dts/Makefile b/arch/loongarch/boot/dts/Makefile >>> index 0e5ed373b1b4..c0464bb8e430 100644 >>> --- a/arch/loongarch/boot/dts/Makefile >>> +++ b/arch/loongarch/boot/dts/Makefile >>> @@ -1,5 +1,6 @@ >>> # SPDX-License-Identifier: GPL-2.0-only >>> >>> -dtb-$(CONFIG_MACH_LOONGSON64) = loongson_2k0500.dtb >>> +dtb-$(CONFIG_MACH_LOONGSON64) = loongson_2k0500.dtb \ >>> + loongson_2k1000.dtb >>> >>> obj-$(CONFIG_BUILTIN_DTB) += $(addsuffix .dtb.o, $(CONFIG_BUILTIN_DTB_NAME)) >>> diff --git a/arch/loongarch/boot/dts/loongson_2k1000.dts b/arch/loongarch/boot/dts/loongson_2k1000.dts >>> new file mode 100644 >>> index 000000000000..9fd9d400d97f >>> --- /dev/null >>> +++ b/arch/loongarch/boot/dts/loongson_2k1000.dts >>> @@ -0,0 +1,565 @@ >>> +// SPDX-License-Identifier: GPL-2.0 >>> + >>> +/dts-v1/; >>> + >>> +#include <dt-bindings/interrupt-controller/irq.h> >>> +#include <dt-bindings/clock/loongson,ls2k-clk.h> >>> +#include <dt-bindings/gpio/gpio.h> >>> + >>> +/ { >>> + model = "LS2K1000 Reference Board"; >>> + compatible = "loongson,ls2k1000"; >>> + >> >> All the same comments apply here. Don't mix SoC (DTSI) with boards. > > Hi Krzysztof: > > I'm very sorry, this is the first time I've written a full DTS. > Do you mean that I need to put the descriptions of these devices into > DTSI and the descriptions of the boards into DTS? You need to clearly identify what is SoC and what is board. Just look for every arm/arm64/riscv example. SoC relevant properties go to SoC DTSI. Board relevant properties go to board DTS. Best regards, Krzysztof