On Fri, Jun 16, 2023 at 5:48 PM Conor Dooley <conor.dooley@xxxxxxxxxxxxx> wrote:
>
> On Fri, Jun 16, 2023 at 02:11:31PM +0800, Binbin Zhou wrote:
>
> > + memalloc@0 {
> > + compatible = "loongson,ls-memalloc";
> > + reg = <0 0x90000000 0 0x20000000>;
> > + };
>
> This is not documented.
Hi Conor:
Sorry, this is my mistake, a private driver will use it, I will try to
remove it in the next version.
>
> > + gpio0: gpio@1fe00500 {
> > + compatible = "loongson,ls2k-gpio", "syscon";
>
> This isn't valid either, the binding doesn't allow syscon?
The syscon is not needed right now. I will remove it.
>
> > + ethernet@3,1 {
> > + compatible = "pci0014,7a03.0",
> > + "pci0014,7a03",
> > + "pciclass,020000",
> > + "pciclass,0200",
> > + "loongson, pci-gmac";
>
> None of the compatibles from here on out are documented either.
These are required to be added according to DeviceTree Spec PCI [1],
Linux does not use these compatible for now.
Removing them really doesn't affect the driver, but to follow the spec
and make sure every node has a compatible, I've left them all in.
Are they not required?
[1]: https://www.openfirmware.info/data/docs/bus.pci.pdf
Thanks.
Binbin
>
> Cheers,
> Conor.
