On Thu, Jun 15, 2023 at 05:52:43PM +0300, Andy Shevchenko wrote: > Insulate of_device_alloc() and of_amba_device_create() from possible > changes to fwnode_handle implementation by using device_set_node() > instead of open-coding dev->dev.fwnode assignments. Side note. When I preparing this change I have noticed a lot of dev_set_name(... dev_name()) in the code which seems to me problematic in two ways: 1) (minor) the dev_set_name() may fail, no checks are there; 2) (major?) the above construction leaks memory. Is it on purpose (esp. second point)? If no, can it be fixed? Note, I'm not familiar with OF platform code, so I would help reviewing the change, but that's it. -- With Best Regards, Andy Shevchenko
