On 12/06/2023 19:07, Jeff LaBundy wrote:
Hi Neil,
[...]
+static const struct input_id goodix_berlin_spi_input_id = {
+ .bustype = BUS_SPI,
+ .vendor = 0x0416,
+ .product = 0x1001,
After having seen these in the I2C counterpart; consider defining them
in goodix_berlin.h.
To be honest, I blindly copied it from goodix.c because the vendor
driver puts random values here.
input_dev->id.product = 0xDEAD;
input_dev->id.vendor = 0xBEEF;
So what should I set ?
If there is no explicit guidance from the vendor, I would simply leave
these unassigned; in theory one would imagine that this controller would
have a different product ID than other models.
I'll leave those unassigned for now, and perhaps we could find
some firmware info value that could be used here.
Neil
[...]
Kind regards,
Jeff LaBundy
