On 6/15/23 04:00, Rob Herring wrote: > On Fri, Jun 02, 2023 at 08:57:37AM +0900, Damien Le Moal wrote: >> On 6/1/23 14:45, Nikita Shubin wrote: >>> Add YAML bindings for ep93xx SoC PATA. >>> >>> Signed-off-by: Nikita Shubin <nikita.shubin@xxxxxxxxxxx> >>> --- >>> >>> Notes: >>> v0 -> v1: >>> >>> - renamed file to ep9312-pata >> >> Looks OK to me but given that this is both for the cirrus,ep9315-pata and >> cirrus,ep9312-pata, wouldn't it be better to name the file >> cirrus,ep931x-pata.yaml ? > > cirrus,ep9312-pata makes sense given that is the common fallback. > > Wildcards are okay in filenames (only) when there's not a common > fallback. Got it. > >>> - changed email to dlemoal@xxxxxxxxxx >>> - dropped label >>> - fixed ident >>> >>> .../bindings/ata/cirrus,ep9312-pata.yaml | 44 +++++++++++++++++++ >>> 1 file changed, 44 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/ata/cirrus,ep9312-pata.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/ata/cirrus,ep9312-pata.yaml b/Documentation/devicetree/bindings/ata/cirrus,ep9312-pata.yaml >>> new file mode 100644 >>> index 000000000000..3489be55a6fe >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/ata/cirrus,ep9312-pata.yaml >>> @@ -0,0 +1,44 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/ata/cirrus,ep9312-pata.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Cirrus Logic EP9312 PATA controller >>> + >>> +maintainers: >>> + - Damien Le Moal <dlemoal@xxxxxxxxxx> >>> + >>> +properties: >>> + compatible: >>> + oneOf: >>> + - const: cirrus,ep9312-pata >> >> I am not a DT specialist, but isn't this line superfluous since it is listed in >> the items ? > > No, this entry is for ep9312. The next entry is for ep9315 which is > compatible with ep9312 version. The cirrus,ep9315-pata is there in case > a distinction (e.g. quirk/errata) needs to be made by the driver > without having to change the DT. Thanks for all the clarification. Looks good then. Acked-by: Damien Le Moal <dlemoal@xxxxxxxxxx> I can take this patch through the ata tree, but it may be better to have it with the entire series (arm tree ?) -- Damien Le Moal Western Digital Research
