Hey Anup, Mostly looks good, once minor comment. On Tue, Jun 13, 2023 at 09:04:12PM +0530, Anup Patel wrote: > + riscv,children: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + minItems: 1 > + maxItems: 1024 > + items: > + maxItems: 1 > + description: > + A list of child APLIC domains for the given APLIC domain. Each child > + APLIC domain is assigned a child index in increasing order, with the > + first child APLIC domain assigned child index 0. The APLIC domain child > + index is used by firmware to delegate interrupts from the given APLIC > + domain to a particular child APLIC domain. > + > + riscv,delegation: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + minItems: 1 > + maxItems: 1024 > + items: > + items: > + - description: child APLIC domain phandle > + - description: first interrupt number of the parent APLIC domain (inclusive) > + - description: last interrupt number of the parent APLIC domain (inclusive) > + description: > + A interrupt delegation list where each entry is a triple consisting > + of child APLIC domain phandle, first interrupt number of the parent > + APLIC domain, and last interrupt number of the parent APLIC domain. > + Firmware must configure interrupt delegation registers based on > + interrupt delegation list. > + > +required: > + - compatible > + - reg > + - interrupt-controller > + - "#interrupt-cells" > + - riscv,num-sources > + > +anyOf: > + - required: > + - interrupts-extended > + - required: > + - msi-parent Not sure if you missed this from the last version, but I asked if we needed a dependencies: riscv,delegate: [ riscv,children ] IOW, I don't think it is valid to have a delegation without having children? Otherwise, Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> Cheers, Conor.
Attachment:
signature.asc
Description: PGP signature
