On Wed, Jun 14, 2023 at 08:53:20AM -0600, Rob Herring wrote: > On Tue, Jun 13, 2023 at 3:11 PM Conor Dooley <conor@xxxxxxxxxx> wrote: > > > > On Tue, Jun 13, 2023 at 02:12:30PM -0600, Rob Herring wrote: > > > The "linux,keycode" property is non-standard. Add the common property > > > "linux,keycodes" and mark "linux,keycode" deprecated so that the mistake > > > is not propagated. > > > > This is actually used in the driver for this device, should the driver > > not also be updated to use the corrected property? > > Yes, but that doesn't have to be in sync with the binding change. I > mainly want to add this so it doesn't get propagated to new users > rather than move this case off of linux,keycode. Also, the input > subsystem should probably have a common function to read > linux,keycodes as right now every driver does it. Perhaps one of the nxp folk in the audience should have a crack at that so. Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> Cheers, Conor.
Attachment:
signature.asc
Description: PGP signature