On Tue, 2023-06-13 at 10:51 +0200, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > On 12/06/2023 12:52, Maso Hunag wrote: > > From: Maso Huang <maso.huang@xxxxxxxxxxxx> > > > > Add mt79xx audio afe document. > > Please use scripts/get_maintainers.pl to get a list of necessary > people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you > base > your patches on recent Linux kernel. > Hi Krzysztif, Thanks for your review. And sorry for missing some necessary maintainers. What's your suggestion, resend these patches again with them, or add them back in v2 patch? > > > > Signed-off-by: Maso Huang <maso.huang@xxxxxxxxxxxx> > > --- > > .../bindings/sound/mediatek,mt79xx-afe.yaml | 102 > ++++++++++++++++++ > > 1 file changed, 102 insertions(+) > > create mode 100644 > Documentation/devicetree/bindings/sound/mediatek,mt79xx-afe.yaml > > > > diff --git > a/Documentation/devicetree/bindings/sound/mediatek,mt79xx-afe.yaml > b/Documentation/devicetree/bindings/sound/mediatek,mt79xx-afe.yaml > > new file mode 100644 > > index 000000000000..11ef1cfdf49b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sound/mediatek,mt79xx- > afe.yaml > > @@ -0,0 +1,102 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/sound/mediatek,mt79xx-afe.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: MediaTek AFE PCM controller for MT79xx > > 79XX sounds weird. Are you sure you are not using wildcards (which > are > not allowed)? > We would like to use mt79xx for mt7986/mt7981/mt7988 series. Or is it better to just use mt7986 for this series? > > + > > +maintainers: > > + - Maso Huang <maso.huang@xxxxxxxxxxxx> > > + > > +properties: > > + compatible: > > + oneOf: > > + - const: mediatek,mt79xx-afe > > + - items: > > + - enum: > > + - mediatek,mt7981-afe > > + - mediatek,mt7986-afe > > + - mediatek,mt7988-afe > > + - const: mediatek,mt79xx-afe > > I already saw AFE, why it cannot be part of existing bindings? > > This list is odd. 79xx, 7981? So it is wildcard? > Yes, it is wildcard for mt7986/mt7981/mt7988 series. Is it better to just use mt7986 for this series? > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + minItems: 5 > > + items: > > + - description: audio bus clock > > + - description: audio 26M clock > > + - description: audio intbus clock > > + - description: audio hopping clock > > + - description: audio pll clock > > + - description: mux for pcm_mck > > + - description: audio i2s/pcm mck > > + > > + clock-names: > > + minItems: 5 > > + items: > > + - const: aud_bus_ck > > + - const: aud_26m_ck > > + - const: aud_l_ck > > + - const: aud_aud_ck > > + - const: aud_eg2_ck > > + - const: aud_sel > > + - const: aud_i2s_m > > Why this is variable? > mt7986/mt7981/mt7988 need different numbers of clock. mt7986 needs first five clocks. mt7981 needs first six clocks. mt7988 needs all seven clocks. > > + > > + assigned-clocks: > > + minItems: 3 > > + maxItems: 4 > > Drop assigned-clocks > > OK, I'll drop it in next patch. > > + > > + assigned-clock-parents: > > + minItems: 3 > > + maxItems: 4 > > Drop > > OK, I'll drop it in next patch. > > Best regards, > Krzysztof > Best regards, Maso
