On 13/06/2023 21.10, Krzysztof Kozlowski wrote: > On 13/06/2023 15:00, Rasmus Villemoes wrote: >> diff --git a/Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml b/Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml >> index d5d3a687a34d..a9ef68b5fdcd 100644 >> --- a/Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml >> +++ b/Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml >> @@ -11,6 +11,13 @@ maintainers: >> >> allOf: >> - $ref: rtc.yaml# >> + # If #clock-cells is present, interrupts must not be present >> + - if: >> + required: >> + - '#clock-cells' >> + then: >> + properties: >> + interrupts: false > > Entire allOf block should be like in example-schema, so before > unevaluatedProperties. Please put it in correct place in your first > patch so here it does not have to be moved. > OK. That first patch was basically a copy-paste of c690048ed59b, and e.g. ingenic,rtc.yaml has a similar non-trivial allOf block between maintainers and properties. Is there somehow I could have known it should be right before unevaluatedProperties? Rasmus
